From c9030dcc5b321abb2afb3a38d00b795081c8fe4d Mon Sep 17 00:00:00 2001 From: Johan Malm Date: Fri, 26 Sep 2025 17:52:13 +0100 Subject: [PATCH] CI: fix broken FreeBSD CI by setting -Dlibsfdo:b_ndebug=false MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit ...because with with meson setup build -Dbuildtype=release -Db_ndebug=true \ --werror --force-fallback-for=libsfdo we get the following warning: In file included from ../subprojects/libsfdo/common/dirs.c:5: ../subprojects/libsfdo/include/common/membuild.h: In function ‘sfdo_membuild_validate’: ../subprojects/libsfdo/include/common/membuild.h:29:65: error: unused parameter ‘membuild’ [-Werror=unused-parameter] 29 | static inline void sfdo_membuild_validate(struct sfdo_membuild *membuild) { ...because `sfdo_membuild_validate()` contains nothing but an `assert()` and that therefore results in an `unused-parameter` warning with `NDEBUG`. https://gitlab.freedesktop.org/vyivel/libsfdo/-/blob/main/include/common/membuild.h?ref_type=heads#L30 --- .github/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b0ff3053..2b76b4d2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -168,6 +168,7 @@ jobs: meson setup build-gcc-release -Dxwayland=enabled \ -Dbuildtype=release -Db_ndebug=true --werror meson configure build-gcc-release -Dwlroots:b_ndebug=false || true + meson configure build-gcc-release -Dlibsfdo:b_ndebug=false || true meson compile -C build-gcc-release ' | $TARGET @@ -190,6 +191,7 @@ jobs: meson setup build-clang-release -Dxwayland=enabled \ -Dbuildtype=release -Db_ndebug=true --werror meson configure build-clang-release -Dwlroots:b_ndebug=false || true + meson configure build-clang-release -Dlibsfdo:b_ndebug=false || true meson compile -C build-clang-release ' | $TARGET -- 2.52.0