From a75301dae506c940b6eeec3042e8b05c3160351d Mon Sep 17 00:00:00 2001 From: John Lindgren Date: Fri, 19 Jul 2024 22:10:24 -0400 Subject: [PATCH] xdg: remove useless view_set_ssd_mode() in xdg_toplevel_new() The desired SSD mode is not known at this point. When it is known, kde-deco/xdg-deco will call view_set_ssd_mode() themselves. --- src/xdg.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/xdg.c b/src/xdg.c index 8ab88c78..f67796da 100644 --- a/src/xdg.c +++ b/src/xdg.c @@ -651,10 +651,6 @@ xdg_toplevel_view_map(struct view *view) if (!view->been_mapped) { init_foreign_toplevel(view); - /* - * FIXME: is this needed or is the earlier logic in - * xdg_surface_new() enough? - */ if (view_wants_decorations(view)) { view_set_ssd_mode(view, LAB_SSD_MODE_FULL); } else { @@ -907,13 +903,6 @@ xdg_toplevel_new(struct wl_listener *listener, void *data) CONNECT_SIGNAL(xdg_surface, xdg_toplevel_view, new_popup); wl_list_insert(&server->views, &view->link); - - /* FIXME: is view_wants_decorations() reliable this early? */ - if (view_wants_decorations(view)) { - view_set_ssd_mode(view, LAB_SSD_MODE_FULL); - } else { - view_set_ssd_mode(view, LAB_SSD_MODE_NONE); - } } void -- 2.52.0