From 107d84cef903b4334e02f66de39a46b33763a2f4 Mon Sep 17 00:00:00 2001 From: Johan Malm Date: Sat, 17 Aug 2024 13:41:10 +0100 Subject: [PATCH] scaled-font-buffer.c: initialize `buffer` to avoid bug waiting to happen --- src/common/scaled-font-buffer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/common/scaled-font-buffer.c b/src/common/scaled-font-buffer.c index f785e2e1..c9382378 100644 --- a/src/common/scaled-font-buffer.c +++ b/src/common/scaled-font-buffer.c @@ -14,13 +14,17 @@ static struct lab_data_buffer * _create_buffer(struct scaled_scene_buffer *scaled_buffer, double scale) { - struct lab_data_buffer *buffer; + struct lab_data_buffer *buffer = NULL; struct scaled_font_buffer *self = scaled_buffer->data; /* Buffer gets free'd automatically along the backing wlr_buffer */ font_buffer_create(&buffer, self->max_width, self->text, &self->font, self->color, self->bg_color, self->arrow, scale); + if (!buffer) { + wlr_log(WLR_ERROR, "font_buffer_create() failed"); + } + self->width = buffer ? buffer->unscaled_width : 0; self->height = buffer ? buffer->unscaled_height : 0; return buffer; -- 2.52.0