From: Johan Malm Date: Fri, 4 Aug 2023 21:04:42 +0000 (+0100) Subject: xwayland: fix client request-unmap bug X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=d961dbf9b04f9e01267503cdd042614a85956e72;p=proto%2Flabwc.git xwayland: fix client request-unmap bug Remove foreign-toplevel handle when a client sends a request-unmap to a minimized (therefore unmapped) view. --- diff --git a/src/xwayland.c b/src/xwayland.c index d456ac52..46e411b6 100644 --- a/src/xwayland.c +++ b/src/xwayland.c @@ -489,7 +489,7 @@ static void xwayland_view_unmap(struct view *view, bool client_request) { if (!view->mapped) { - return; + goto out; } view->mapped = false; wl_list_remove(&view->commit.link); @@ -501,6 +501,7 @@ xwayland_view_unmap(struct view *view, bool client_request) * than just minimized), destroy the foreign toplevel handle so * the unmapped view doesn't show up in panels and the like. */ +out: if (client_request && view->toplevel.handle) { wlr_foreign_toplevel_handle_v1_destroy(view->toplevel.handle); view->toplevel.handle = NULL;