From: Johan Malm <jgm323@gmail.com>
Date: Sun, 2 Jul 2023 20:20:04 +0000 (+0100)
Subject: action.c: remove duplicate code
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=d0b52139edcc44afcea727503f029afc1d7848f6;p=proto%2Flabwc.git

action.c: remove duplicate code
---

diff --git a/src/action.c b/src/action.c
index 11cb6fcf..dc06bdf0 100644
--- a/src/action.c
+++ b/src/action.c
@@ -168,15 +168,12 @@ action_arg_from_xml_node(struct action *action, char *nodename, char *content)
 
 	switch (action->type) {
 	case ACTION_TYPE_EXECUTE:
-		if (!strcmp(argument, "command")) {
-			action_arg_add_str(action, argument, content);
-			goto cleanup;
-		} else if (!strcmp(argument, "execute")) {
-			/*
-			 * <action name="Execute"><execute>foo</execute></action>
-			 * is deprecated, but we support it anyway for backward
-			 * compatibility with old openbox-menu generators
-			 */
+		/*
+		 * <action name="Execute"> with an <execute> child is
+		 * deprecated, but we support it anyway for backward
+		 * compatibility with old openbox-menu generators
+		 */
+		if (!strcmp(argument, "command") || !strcmp(argument, "execute")) {
 			action_arg_add_str(action, "command", content);
 			goto cleanup;
 		}