From: Johan Malm <jgm323@gmail.com>
Date: Mon, 18 Oct 2021 18:40:04 +0000 (+0100)
Subject: foreign: remove unnecessary view_update_title()
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=cf1bd67ec188fbcdbe8c9f3789b91b1f1fd6e39d;p=proto%2Flabwc.git

foreign: remove unnecessary view_update_title()

View update title is called from view_impl_map() which is enough
---

diff --git a/src/foreign.c b/src/foreign.c
index 64a03c9b..0a0824aa 100644
--- a/src/foreign.c
+++ b/src/foreign.c
@@ -39,7 +39,6 @@ foreign_toplevel_handle_create(struct view *view)
 		return;
 	}
 
-	view_update_title(view);
 	struct wlr_output *wlr_output = view_wlr_output(view);
 	if (!wlr_output) {
 		wlr_log(WLR_ERROR, "no wlr_output for (%s)",
@@ -53,13 +52,15 @@ foreign_toplevel_handle_create(struct view *view)
 		handle_toplevel_handle_request_maximize;
 	wl_signal_add(&view->toplevel_handle->events.request_maximize,
 		&view->toplevel_handle_request_maximize);
+
 	view->toplevel_handle_request_minimize.notify =
 		handle_toplevel_handle_request_minimize;
 	wl_signal_add(&view->toplevel_handle->events.request_minimize,
 		&view->toplevel_handle_request_minimize);
+
 	view->toplevel_handle_request_fullscreen.notify =
 		handle_toplevel_handle_request_fullscreen;
 	wl_signal_add(&view->toplevel_handle->events.request_fullscreen,
 		&view->toplevel_handle_request_fullscreen);
-	// TODO: hook up remaining signals (close)
+	/* TODO: hook up remaining signals (close, destroy, activate) */
 }