From: tokyo4j <hrak1529@gmail.com>
Date: Fri, 4 Oct 2024 07:44:55 +0000 (+0900)
Subject: xdg: fix crash on actions from menu opened by show_window_menu requests
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=c413e65a20a006d5703cb0a7d74c4c4016194ac5;p=proto%2Flabwc.git

xdg: fix crash on actions from menu opened by show_window_menu requests

Also removed a redundant line in show_menu() in action.c.
---

diff --git a/src/action.c b/src/action.c
index c19810c1..810026a6 100644
--- a/src/action.c
+++ b/src/action.c
@@ -734,7 +734,6 @@ show_menu(struct server *server, struct view *view, struct cursor_context *ctx,
 
 	/* Replaced by next show_menu() or cleaned on view_destroy() */
 	menu->triggered_by_view = view;
-	menu->server->menu_current = menu;
 	menu_open_root(menu, x, y);
 }
 
diff --git a/src/xdg.c b/src/xdg.c
index b92a34a6..5184fea4 100644
--- a/src/xdg.c
+++ b/src/xdg.c
@@ -418,8 +418,11 @@ handle_request_show_window_menu(struct wl_listener *listener, void *data)
 	struct xdg_toplevel_view *xdg_toplevel_view = wl_container_of(
 		listener, xdg_toplevel_view, request_show_window_menu);
 	struct server *server = xdg_toplevel_view->base.server;
+
 	struct menu *menu = menu_get_by_id(server, "client-menu");
 	assert(menu);
+	menu->triggered_by_view = &xdg_toplevel_view->base;
+
 	struct wlr_cursor *cursor = server->seat.cursor;
 	menu_open_root(menu, cursor->x, cursor->y);
 }