From: Johan Malm <jgm323@gmail.com>
Date: Wed, 13 Aug 2025 20:37:51 +0000 (+0100)
Subject: menu: fix leak in update_client_send_to_menu()
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=8bcea29a1c26dff05aeaaae833a37d880e161434;p=proto%2Flabwc.git

menu: fix leak in update_client_send_to_menu()
---

diff --git a/src/menu/menu.c b/src/menu/menu.c
index f610c1c3..8e3c004a 100644
--- a/src/menu/menu.c
+++ b/src/menu/menu.c
@@ -844,8 +844,8 @@ update_client_send_to_menu(struct server *server)
 	 * <action name="SendToDesktop"><follow> is true by default so
 	 * GoToDesktop will be called as part of the action.
 	 */
+	struct buf buf = BUF_INIT;
 	wl_list_for_each(workspace, &server->workspaces.all, link) {
-		struct buf buf = BUF_INIT;
 		if (workspace == server->workspaces.current) {
 			buf_add_fmt(&buf, ">%s<", workspace->name);
 		} else {
@@ -859,6 +859,7 @@ update_client_send_to_menu(struct server *server)
 
 		buf_clear(&buf);
 	}
+	buf_reset(&buf);
 
 	separator_create(menu, "");
 	struct menuitem *item = item_create(menu,