From: Liam Middlebrook <lmiddlebrook@nvidia.com>
Date: Thu, 20 Jan 2022 19:38:23 +0000 (-0800)
Subject: output: Add option to preview the contents of the current cycle_view
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=875b25860293c2c8a3a8f977859492c0bcae330b;p=proto%2Flabwc.git

output: Add option to preview the contents of the current cycle_view

Add the 'cycleViewPreview.core' option to rc.xml to enable previews of
the selected view when cycling between windows. Default this option to
be disabled to match current behavior.
---

diff --git a/docs/labwc-config.5.scd b/docs/labwc-config.5.scd
index a27261ae..8f352ac3 100644
--- a/docs/labwc-config.5.scd
+++ b/docs/labwc-config.5.scd
@@ -31,6 +31,10 @@ Configuration must be wrapped in a <labwc_config> root-node.
 *<core><adaptiveSync>* [yes|no]
 	Enable adaptive sync. Default is no.
 
+*<core><cycleViewPreview>* [yes|no]
+	Preview the contents of the selected window when cycling between windows.
+	Default is no.
+
 # FOCUS
 
 *<focus><followMouse>* [yes|no]
diff --git a/docs/rc.xml.all b/docs/rc.xml.all
index 0f724dfd..f3e29eea 100644
--- a/docs/rc.xml.all
+++ b/docs/rc.xml.all
@@ -11,6 +11,7 @@
     <decoration>server</decoration>
     <gap>0</gap>
     <adaptiveSync>no</adaptiveSync>
+    <cycleViewPreview>no</cycleViewPreview>
   </core>
 
   <!--
diff --git a/include/config/rcxml.h b/include/config/rcxml.h
index 42d66283..934f742f 100644
--- a/include/config/rcxml.h
+++ b/include/config/rcxml.h
@@ -48,6 +48,9 @@ struct rcxml {
 	/* window snapping */
 	int snap_edge_range;
 	bool snap_top_maximize;
+
+	/* cycle view (alt+tab) */
+	bool cycle_preview_contents;
 };
 
 extern struct rcxml rc;
diff --git a/src/config/rcxml.c b/src/config/rcxml.c
index 104211f0..588f8cdb 100644
--- a/src/config/rcxml.c
+++ b/src/config/rcxml.c
@@ -384,6 +384,8 @@ entry(xmlNode *node, char *nodename, char *content)
 		rc.snap_edge_range = atoi(content);
 	} else if (!strcasecmp(nodename, "topMaximize.snapping")) {
 		rc.snap_top_maximize = get_bool(content);
+	} else if (!strcasecmp(nodename, "cycleViewPreview.core")) {
+		rc.cycle_preview_contents = get_bool(content);
 	}
 }
 
@@ -482,6 +484,7 @@ rcxml_init()
 	rc.screen_edge_strength = 20;
 	rc.snap_edge_range = 1;
 	rc.snap_top_maximize = true;
+	rc.cycle_preview_contents = false;
 }
 
 static struct {
diff --git a/src/output.c b/src/output.c
index 5be22038..bccfb12c 100644
--- a/src/output.c
+++ b/src/output.c
@@ -802,6 +802,16 @@ output_render(struct output *output, pixman_region32_t *damage)
 
 	/* 'alt-tab' border */
 	if (output->server->cycle_view) {
+		/* If the 'cycle_preview_contents' option is set in
+		 * rc.xml, render the contents of the cycle_view over
+		 * all other views (except for the OSD)
+		 */
+		if (rc.cycle_preview_contents) {
+			render_deco(output->server->cycle_view, output, damage);
+			render_view_toplevels(output->server->cycle_view, output, damage);
+			render_view_popups(output->server->cycle_view, output, damage);
+		}
+
 		render_cycle_box(output, damage, output->server->cycle_view);
 		render_osd(output, damage, output->server);
 	}