From: John Lindgren <john@jlindgren.net>
Date: Wed, 14 Feb 2024 08:13:12 +0000 (-0500)
Subject: view: remove view_is_related(), no longer used
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=6a35e8e78c77af0221d9f8ef8d119f35386fc710;p=proto%2Flabwc.git

view: remove view_is_related(), no longer used
---

diff --git a/include/view.h b/include/view.h
index 53534670..4a7cc207 100644
--- a/include/view.h
+++ b/include/view.h
@@ -108,8 +108,6 @@ struct view_impl {
 	void (*move_to_back)(struct view *view);
 	struct view *(*get_root)(struct view *self);
 	void (*append_children)(struct view *self, struct wl_array *children);
-	/* determines if view and surface are owned by the same process */
-	bool (*is_related)(struct view *self, struct wlr_surface *surface);
 	struct view_size_hints (*get_size_hints)(struct view *self);
 	/* if not implemented, VIEW_WANTS_FOCUS_ALWAYS is assumed */
 	enum view_wants_focus (*wants_focus)(struct view *self);
@@ -462,13 +460,6 @@ struct view *view_get_root(struct view *view);
 void view_append_children(struct view *view, struct wl_array *children);
 bool view_on_output(struct view *view, struct output *output);
 
-/**
- * view_is_related() - determine if view and surface are owned by the
- * same application/process. Currently only implemented for xwayland
- * views/surfaces.
- */
-bool view_is_related(struct view *view, struct wlr_surface *surface);
-
 /**
  * view_has_strut_partial() - returns true for views that reserve space
  * at a screen edge (e.g. panels). These views are treated as if they
diff --git a/src/view.c b/src/view.c
index a99ef91b..e8616614 100644
--- a/src/view.c
+++ b/src/view.c
@@ -2007,17 +2007,6 @@ view_append_children(struct view *view, struct wl_array *children)
 	}
 }
 
-bool
-view_is_related(struct view *view, struct wlr_surface *surface)
-{
-	assert(view);
-	assert(surface);
-	if (view->impl->is_related) {
-		return view->impl->is_related(view, surface);
-	}
-	return false;
-}
-
 bool
 view_has_strut_partial(struct view *view)
 {
diff --git a/src/xwayland.c b/src/xwayland.c
index 8f3ac1e3..85e57f29 100644
--- a/src/xwayland.c
+++ b/src/xwayland.c
@@ -792,17 +792,6 @@ xwayland_view_append_children(struct view *self, struct wl_array *children)
 	}
 }
 
-static bool
-xwayland_view_is_related(struct view *view, struct wlr_surface *surface)
-{
-	struct wlr_xwayland_surface *xsurface =
-		xwayland_surface_from_view(view);
-	struct wlr_xwayland_surface *xsurface2 =
-		wlr_xwayland_surface_try_from_wlr_surface(surface);
-
-	return (xsurface2 && xsurface2->pid == xsurface->pid);
-}
-
 static void
 xwayland_view_set_activated(struct view *view, bool activated)
 {
@@ -837,7 +826,6 @@ static const struct view_impl xwayland_view_impl = {
 	.move_to_back = xwayland_view_move_to_back,
 	.get_root = xwayland_view_get_root,
 	.append_children = xwayland_view_append_children,
-	.is_related = xwayland_view_is_related,
 	.get_size_hints = xwayland_view_get_size_hints,
 	.wants_focus = xwayland_view_wants_focus,
 	.has_strut_partial = xwayland_view_has_strut_partial,