From: Michael D. Lowis <mike@mdlowis.com>
Date: Wed, 1 Aug 2018 01:58:51 +0000 (-0400)
Subject: fixed a bug when dropping card onto child element of itself
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=60483e36048056dbcc208ea2bc3d09d3f3c75bcd;p=proto%2Fkanban.git

fixed a bug when dropping card onto child element of itself
---

diff --git a/index.html b/index.html
index 10c24a6..5686123 100644
--- a/index.html
+++ b/index.html
@@ -155,7 +155,9 @@ h2 {
 
     <script>
 'use strict';
-(() => {
+//(() => {
+    const childOf = (p,e) => e && (e === p || childOf(p, e.parentNode));
+
     const drag_start = (ev) => {
         ev.target.id = "selected-card";
         ev.dataTransfer.setData("text/plain", ev.target.id);
@@ -173,15 +175,15 @@ h2 {
         ev.preventDefault();
         const tgt = ev.target;
         const data = document.getElementById(ev.dataTransfer.getData("text"));
+        Array.from(document.getElementsByClassName("drag-target")).forEach((e) => e.classList.remove("drag-target"));
+        data.id = "";
         if (tgt.tagName === "H2") {
             tgt.parentNode.appendChild(data);
         } else if (tgt.classList.contains("card")) {
             tgt.parentNode.insertBefore(data, tgt);
-        } else {
+        } else if (!childOf(data, tgt)) {
             tgt.appendChild(data);
         }
-        data.id = "";
-        Array.from(document.getElementsByClassName("drag-target")).forEach((e) => e.classList.remove("drag-target"));
     }
 
     window.onclick = (ev) => {
@@ -216,7 +218,7 @@ h2 {
         cards[i].ondragstart = drag_start;
         cards[i].draggable = true;
     }
-})();
+//})();
     </script>
 </body>
 </html>