From: John Lindgren <john@jlindgren.net>
Date: Sat, 11 Nov 2023 03:00:04 +0000 (-0500)
Subject: keyboard: remove nr_pressed_keys == 1 restriction for keybindings
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=5a77a3ad5176b09ff8576b8a6d05e53bcb4302d1;p=proto%2Flabwc.git

keyboard: remove nr_pressed_keys == 1 restriction for keybindings

This restriction should be unnecessary now (see the previous commit for
details) and caused issues with keybindings not working on some systems
where irregular keypress events are received (e.g. XF86XK_WakeUp)
without an accompanying release event.

Kept separate from the previous commit for the sake of potential future
bisects.

Partially reverts e77330bc3fe7.
---

diff --git a/src/input/keyboard.c b/src/input/keyboard.c
index b99555d6..005fa263 100644
--- a/src/input/keyboard.c
+++ b/src/input/keyboard.c
@@ -359,19 +359,6 @@ handle_compositor_keybindings(struct keyboard *keyboard,
 		goto out;
 	}
 
-	/*
-	 * A keybind is not considered valid if other keys are pressed at the
-	 * same time.
-	 *
-	 * In labwc, a keybind is defined by one/many modifier keys + _one_
-	 * non-modifier key. Returning early on >1 pressed non-modifier keys
-	 * avoids false positive matches where 'other' keys were pressed at the
-	 * same time.
-	 */
-	if (key_state_nr_pressed_keys() > 1) {
-		return false;
-	}
-
 	/*
 	 * Handle compositor keybinds
 	 *