From: John Lindgren <john@jlindgren.net>
Date: Wed, 13 Dec 2023 22:37:14 +0000 (-0500)
Subject: output: do not call wlr_scene_output_layout_add_output() twice
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=447c67df62ea0187162c041736338f8c7f128309;p=proto%2Flabwc.git

output: do not call wlr_scene_output_layout_add_output() twice

Fixes an assertion failure that occurred if reconfiguring outputs after
an output had been disabled using wlopm --off.

Fixes: #1303
---

diff --git a/src/output.c b/src/output.c
index 6d7048bf..eaec44bb 100644
--- a/src/output.c
+++ b/src/output.c
@@ -158,10 +158,14 @@ add_output_to_layout(struct server *server, struct output *output)
 			wlr_log(WLR_ERROR, "unable to create scene output");
 			return;
 		}
+		/*
+		 * Note: wlr_scene_output_layout_add_output() is not
+		 * safe to call twice, so we call it only when initially
+		 * creating the scene_output.
+		 */
+		wlr_scene_output_layout_add_output(server->scene_layout,
+			layout_output, output->scene_output);
 	}
-
-	wlr_scene_output_layout_add_output(server->scene_layout, layout_output,
-		output->scene_output);
 }
 
 static void