From: tokyo4j <hrak1529@gmail.com>
Date: Sun, 8 Dec 2024 07:05:53 +0000 (+0900)
Subject: Revert "menu: slightly slide menus opened from buttons"
X-Git-Url: https://git.mdlowis.com/?a=commitdiff_plain;h=21bd5b00;p=proto%2Flabwc.git

Revert "menu: slightly slide menus opened from buttons"

With 2ade6a1, negative x-values can be passed to menu_configure() when the
window menu is opened from top-left button in a maximized window, but
wlr_output_layout_output_at() couldn't find the output for the coordinate
since it's out of the output layout, thus it just opened the menu without
updating its position.

As the next release is close and the visual improvement by 2ade6a1 is not
very impactful for UX, let's revert it for now.
---

diff --git a/src/action.c b/src/action.c
index 195a9171..9da1b796 100644
--- a/src/action.c
+++ b/src/action.c
@@ -678,7 +678,6 @@ show_menu(struct server *server, struct view *view, struct cursor_context *ctx,
 			assert(ctx->node);
 			int ly;
 			wlr_scene_node_coords(ctx->node, &x, &ly);
-			x -= server->theme->menu_border_width;
 		}
 	}