]> git.mdlowis.com Git - proto/labwc.git/commitdiff
keybind: pointer to string literal should be const
authorJohn Lindgren <john@jlindgren.net>
Fri, 4 Jul 2025 04:18:53 +0000 (00:18 -0400)
committerConsolatis <35009135+Consolatis@users.noreply.github.com>
Mon, 21 Jul 2025 14:51:10 +0000 (16:51 +0200)
Assigning to (char*) creates a mutable string literal, which was
likely not intended here and wasn't necessary.

src/config/keybind.c

index 5e5002f76f3c08ae41d1053d767c538072c83d95..d59b64eb67f5799b4c7cc95143807160a515ff87 100644 (file)
@@ -123,7 +123,7 @@ keybind_create(const char *keybind)
        xkb_keysym_t keysyms[MAX_KEYSYMS];
        gchar **symnames = g_strsplit(keybind, "-", -1);
        for (size_t i = 0; symnames[i]; i++) {
-               char *symname = symnames[i];
+               const char *symname = symnames[i];
                /*
                 * Since "-" is used as a separator, a keybind string like "W--"
                 * becomes "W", "", "". This means that it is impossible to bind