]> git.mdlowis.com Git - proto/labwc.git/commitdiff
xdg: remove useless view_set_ssd_mode() in xdg_toplevel_new()
authorJohn Lindgren <john@jlindgren.net>
Sat, 20 Jul 2024 02:10:24 +0000 (22:10 -0400)
committerJohn Lindgren <john@jlindgren.net>
Sat, 20 Jul 2024 14:57:44 +0000 (10:57 -0400)
The desired SSD mode is not known at this point. When it is known,
kde-deco/xdg-deco will call view_set_ssd_mode() themselves.

src/xdg.c

index 8ab88c7844f449ded19047674fc0955e6acd91de..f67796da3627c98bf9a020f61c05aecd8fc24ecd 100644 (file)
--- a/src/xdg.c
+++ b/src/xdg.c
@@ -651,10 +651,6 @@ xdg_toplevel_view_map(struct view *view)
        if (!view->been_mapped) {
                init_foreign_toplevel(view);
 
-               /*
-                * FIXME: is this needed or is the earlier logic in
-                * xdg_surface_new() enough?
-                */
                if (view_wants_decorations(view)) {
                        view_set_ssd_mode(view, LAB_SSD_MODE_FULL);
                } else {
@@ -907,13 +903,6 @@ xdg_toplevel_new(struct wl_listener *listener, void *data)
        CONNECT_SIGNAL(xdg_surface, xdg_toplevel_view, new_popup);
 
        wl_list_insert(&server->views, &view->link);
-
-       /* FIXME: is view_wants_decorations() reliable this early? */
-       if (view_wants_decorations(view)) {
-               view_set_ssd_mode(view, LAB_SSD_MODE_FULL);
-       } else {
-               view_set_ssd_mode(view, LAB_SSD_MODE_NONE);
-       }
 }
 
 void