]> git.mdlowis.com Git - proto/labwc.git/commitdiff
Revert "config: support <mouse><default />"
authorConsolatis <35009135+Consolatis@users.noreply.github.com>
Tue, 26 Apr 2022 17:38:14 +0000 (19:38 +0200)
committerConsolatis <35009135+Consolatis@users.noreply.github.com>
Tue, 26 Apr 2022 17:56:06 +0000 (19:56 +0200)
This reverts commit 3d337857b7b0edb76083b4e6a7e15abfb288182a.

Revert for now until we have some infrastructure in place to
selectively replace default {key,mouse}binds with custom ones.

Fixes #304
Reported-by: @01micko
docs/labwc-config.5.scd
src/config/rcxml.c
src/cursor.c

index f3a8aa5e44276bce90f9cf17e1d392d656224a9f..a58546cc967d9bba18354fd654fa345a9952b641 100644 (file)
@@ -160,13 +160,6 @@ Configuration must be wrapped in a <labwc_config> root-node.
        - DoubleClick: Two presses within the doubleClickTime.
        - Drag: Pressing the button within the context, then moving the cursor
 
-*<mouse><default />*
-       Load default mousebinds. This is an addition to the openbox
-       specification and provides a way to keep config files simpler whilst
-       allowing user specific binds.  Note that if no rc.xml is found, or if no
-       <mouse><mousebind> entries exist, the same default mousebinds will be
-       loaded even if the <default /> element is not provided.
-
 # LIBINPUT
 
 *<libinput><device category="">*
index 176980a2a82196c8617a5c517654badde8c08f82..894ca5fa610f600cabe0061fa61bed11b7df35e1 100644 (file)
@@ -41,7 +41,6 @@ enum font_place {
 };
 
 static void load_default_key_bindings(void);
-static void load_default_mouse_bindings(void);
 
 static void
 fill_keybind(char *nodename, char *content)
@@ -334,9 +333,6 @@ entry(xmlNode *node, char *nodename, char *content)
        if (!strcmp(nodename, "default.keyboard")) {
                load_default_key_bindings();
                return;
-       } else if (!strcmp(nodename, "default.mouse")) {
-               load_default_mouse_bindings();
-               return;
        }
 
        /* handle the rest */
index 663ecb809f9e09ee6f3fda20cb9c7e8a81306599..7d3669f3ad6cabb5a77f9b0dd3d0b99f11d38ef1 100644 (file)
@@ -619,7 +619,7 @@ handle_press_mousebinding(struct view *view, struct server *server,
        bool activated_any = false;
        bool activated_any_frame = false;
 
-       wl_list_for_each(mousebind, &rc.mousebinds, link) {
+       wl_list_for_each_reverse(mousebind, &rc.mousebinds, link) {
                if (ssd_part_contains(mousebind->context, view_area)
                                && mousebind->button == button
                                && modifiers == mousebind->modifiers) {
@@ -655,7 +655,6 @@ handle_press_mousebinding(struct view *view, struct server *server,
                        activated_any = true;
                        activated_any_frame |= mousebind->context == LAB_SSD_FRAME;
                        actions_run(view, server, &mousebind->actions, resize_edges);
-                       break;
                }
        }
        return activated_any && activated_any_frame;