menu: ignore <item> without parent <menu>

...to avoid assert() in item_create() because current_menu is NULL.

Reproduce crash with...

    <?xml version="1.0" encoding="utf-8"?>
    <openbox_menu>
      <item label="foo"/>
    </openbox_menu>

diff --git a/src/menu/menu.c b/src/menu/menu.c
index a30fcba2c3112b3bc4c1f19249379f51eb457ce5..9342ab28c8e5cc26cbb4e67af46f07be5159adc9 100644 (file)
--- a/src/menu/menu.c
+++ b/src/menu/menu.c
@@ -605,6 +605,11 @@ xml_tree_walk(xmlNode *node, struct server *server)
                        continue;
                }
                if (!strcasecmp((char *)n->name, "item")) {
+                       if (!current_menu) {
+                               wlr_log(WLR_ERROR,
+                                       "ignoring <item> without parent <menu>");
+                               continue;
+                       }
                        in_item = true;
                        traverse(n, server);
                        in_item = false;