menu: move already-on-selected-item check

...menu_process_item_selection() as the previous variant did not work.

diff --git a/src/menu/menu.c b/src/menu/menu.c
index b10b46cd8ea14cc07bc32553f369d4bbcefec5e8..e58c2fe06b70740a0ac5337e0d449586d7a86694 100644 (file)
--- a/src/menu/menu.c
+++ b/src/menu/menu.c
@@ -874,6 +874,13 @@ menu_process_item_selection(struct menuitem *item)
 {
        assert(item);
 
+       /* Do not keep selecting the same item */
+       static struct menuitem *last;
+       if (item == last) {
+               return;
+       }
+       last = item;
+
        if (!item->selectable) {
                return;
        }
@@ -1042,12 +1049,6 @@ menu_process_cursor_motion(struct wlr_scene_node *node)
 {
        assert(node && node->data);
        struct menuitem *item = node_menuitem_from_node(node);
-
-       if (item->selectable && node == &item->selected.tree->node) {
-               /* We are on an already selected item */
-               return;
-       }
-
        menu_process_item_selection(item);
 }