]> git.mdlowis.com Git - proto/labwc.git/commit
Revert "src/interactive.c: don't unshade when view is un-tiled by dragging"
authorAndrew J. Hesford <ajh@sideband.org>
Tue, 27 Aug 2024 14:10:53 +0000 (10:10 -0400)
committerAndrew J. Hesford <ajh@sideband.org>
Wed, 28 Aug 2024 12:24:26 +0000 (08:24 -0400)
commitb34f2c9d85a52bc19a9458b6d38bae64fae55baa
tree2d9543896ce3c7d138ff11834336cc04a0fe0ef9
parent1f1bdad0873561d32c39674f5808931ef8880bec
Revert "src/interactive.c: don't unshade when view is un-tiled by dragging"

When labwc un-tiles views, it generally changes their size, which sends
a configure request to the client. However, because the view has been
disabled in the wlroots scene, it will not receive and process the
configure when labwc expects. Instead, the handling will be deferred
until the user unshades the view at some arbitrary time in the future,
resulting in labwc registering complains like

    [../src/xdg.c:239] client did not respond to configure request in 100 ms

Furthermore, the reconfigure will still generally produce flicker (as
the view opens in its tiled size and then jumps to its natural
geometry). Because skipping the unshade might cause client problems and
doesn't eliminate the problem it sought to resolve, let's revert this.

This reverts commit 2e19bd4d5b3c67c27d13be24d41a0ea9ba2f1626.
src/input/cursor.c
src/interactive.c