]> git.mdlowis.com Git - proto/labwc.git/commit
img: fix apparent double-free in img_svg_render() failure path
authorJohn Lindgren <john@jlindgren.net>
Sun, 13 Jul 2025 01:30:26 +0000 (21:30 -0400)
committerHiroaki Yamamoto <hrak1529@gmail.com>
Sun, 13 Jul 2025 07:43:56 +0000 (16:43 +0900)
commit359dd8f3c7a400a89613d013e5b9ba5647cdd476
tree956affbdba5b5d995048c5bffddb356d2b5f3010
parentbb2d34a5c12b2d4d6f30d0e9f4dd3cb8f110bfb6
img: fix apparent double-free in img_svg_render() failure path

img_svg_render() calls g_object_unref() on the RsvgHandle in its
error path, but the handle is owned by the shared lab_img_data
struct and will be double-freed later by lab_img_destroy().

The double-free was introduced when img_svg_load() was split from
img_svg_render(). The g_object_unref() should have been removed from
img_svg_render() but was missed.

Fixes: 16dbdc64e58d66011bbf319b92de844dab0ca8d9
("ssd: rework titlebar button rendering")
src/img/img-svg.c